refactor: provide default implementation for send_raw_transaction#19564
Merged
refactor: provide default implementation for send_raw_transaction#19564
Conversation
klkvr
requested review from
Rjected,
RomanHodulak,
fgimenez and
mattsse
as code owners
mattsse
approved these changes
Nov 6, 2025
Comment on lines
40
to
41
| /// | ||
| /// Returns the hash of the transaction. |
Collaborator
There was a problem hiding this comment.
I think we can remove all the docs here because trait fn
mattsse
added
C-enhancement
yongkangc
pushed a commit
that referenced
this pull request
Nov 7, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
EthTransactionstrait:send_transactionis renamed tosend_transaction_requestsend_transactionis introduced which acceptsWithEncoded<Recovered<PooledTx>>and is expected to have the same behavior assend_raw_transactioncurrentlysend_raw_transactionis providedthe idea is to allow conditionally routing transactions without requiring to do decoding twice