feat(executor): transaction and receipts verification#195
Merged
Conversation
rakita
force-pushed
the
rakita/tx_receipt_verification
branch
from
2a7f1b1 to
dada514
Compare
Merged
rakita
force-pushed
the
rakita/tx_receipt_verification
branch
from
6559153 to
54ed125
Compare
Codecov Report
@@ Coverage Diff @@
## main #195 +/- ##
==========================================
+ Coverage 67.74% 68.27% +0.53%
==========================================
Files 213 214 +1
Lines 18142 18064 -78
==========================================
+ Hits 12290 12334 +44
+ Misses 5852 5730 -122
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rakita
force-pushed
the
rakita/tx_receipt_verification
branch
from
dd76362 to
5c9221f
Compare
mattsse
approved these changes
Nov 15, 2022
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
smol nit.
will also convert corresponding values to u128 in txpool once this is merged
crates/primitives/src/lib.rs
Outdated
Comment on lines
+101
to
+110
|
|
||
| use hex_literal::hex; | ||
|
|
||
| /// Keccak256 over empty array. | ||
| pub const KECCAK_EMPTY: H256 = | ||
| H256(hex!("c5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470")); | ||
|
|
||
| /// Ommer root of empty list. | ||
| pub const EMPTY_OMMER_ROOT: H256 = | ||
| H256(hex!("1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347")); |
emhane
pushed a commit
to JoshdfG/reth
that referenced
this pull request
Jan 5, 2026
Closes paradigmxyz#179 --------- Co-authored-by: Julian Meyer <julian.meyer@coinbase.com>
JoshdfG
pushed a commit
to JoshdfG/reth
that referenced
this pull request
Jan 16, 2026
Closes paradigmxyz#179 --------- Co-authored-by: Julian Meyer <julian.meyer@coinbase.com>
emhane
pushed a commit
to JoshdfG/reth
that referenced
this pull request
Jan 21, 2026
Closes paradigmxyz#179 --------- Co-authored-by: Julian Meyer <julian.meyer@coinbase.com>
dhyaniarun1993
added a commit
to dhyaniarun1993/reth
that referenced
this pull request
Feb 23, 2026
Closes paradigmxyz#179 --------- Co-authored-by: Julian Meyer <julian.meyer@coinbase.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transaction and receipts verification.
Removal of receipts from a sealed block( as in all cases they are not obtained from outside but generated inside executor) and receipt root is checked for verification after execution.
left it as draft and will promote it after EIP check and merger of #190
Things left for verification are difficulty, extra_data and pow stuff (mix_hash/nonce) and I will need to go over EIP's to double check when and what needs to be enabled/disabled.
edit: done, they are disabled after the merge, before the merge check should be done for consistency but it is low priority as it does not matter a lot for consensus as we sync from the chain tip.
Transaction price-related fields are promoted to
u128just to be safe, and txvalueis put as u128 (from U256) as there is no amount of eth that can overflow u128.