chore: make extra_data_size_limit configurable in EthBeaconConsensus#19496
Merged
mattsse merged 10 commits intoparadigmxyz:mainfrom Nov 12, 2025
Merged
chore: make extra_data_size_limit configurable in EthBeaconConsensus#19496mattsse merged 10 commits intoparadigmxyz:mainfrom
extra_data_size_limit configurable in EthBeaconConsensus#19496mattsse merged 10 commits intoparadigmxyz:mainfrom
Conversation
Peponks9
requested review from
Rjected,
fgimenez,
mattsse,
mediocregopher and
yongkangc
as code owners
mattsse
added
C-enhancement
mattsse
requested changes
Nov 5, 2025
Comment on lines
-935
to
-937
| /// The header is required as an arg, because we might be checking that the header is a fork | ||
| /// block before it's in the tree state and before it's in the database. | ||
| fn is_fork(&self, target: BlockWithParent) -> ProviderResult<bool> { |
Collaborator
There was a problem hiding this comment.
looks like you made these changes on top of your other pr
midn separating this?
Comment on lines
+41
to
+42
| /// Maximum allowed extra data size in bytes | ||
| pub max_extra_data_size: usize, |
Collaborator
There was a problem hiding this comment.
this should be private and instead have a getter and a fn with_max_extra_data_size builder style fn
| /// Create a new instance of [`EthBeaconConsensus`] | ||
| pub const fn new(chain_spec: Arc<ChainSpec>) -> Self { | ||
| Self { chain_spec } | ||
| Self { chain_spec, max_extra_data_size: 32 } |
Collaborator
There was a problem hiding this comment.
this should use the constant
Comment on lines
+49
to
+50
| /// Maximum allowed extra data size in bytes | ||
| pub max_extra_data_size: usize, |
Peponks9
force-pushed
the
feat/configurable-extra-data-limit
branch
from
93fbdfc to
3203423
Compare
Peponks9
commented
Nov 8, 2025
Contributor
Author
Peponks9
left a comment
Peponks9
left a comment
There was a problem hiding this comment.
thanks Matt, changes done. Just investigation on the remaining error
Peponks9
force-pushed
the
feat/configurable-extra-data-limit
branch
from
5d28184 to
901e652
Compare
klkvr
reviewed
Nov 10, 2025
Member
There was a problem hiding this comment.
don't think changes here are relevant?
Contributor
Author
There was a problem hiding this comment.
yes, fixing it right away
Peponks9
force-pushed
the
feat/configurable-extra-data-limit
branch
from
901e652 to
5d59d09
Compare
klkvr
requested changes
Nov 11, 2025
Comment on lines
+34
to
+35
| /// Default maximum extra data size in bytes (32 bytes as per Ethereum spec). | ||
| const DEFAULT_MAX_EXTRA_DATA_SIZE: usize = 32; |
Member
There was a problem hiding this comment.
let's use the alloy_consensus constant instead
Comment on lines
+42
to
+43
| /// Default maximum extra data size in bytes (32 bytes as per Ethereum spec). | ||
| const DEFAULT_MAX_EXTRA_DATA_SIZE: usize = 32; |
klkvr
approved these changes
Nov 12, 2025
emhane
pushed a commit
to op-rs/op-reth
that referenced
this pull request
Nov 24, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19428
cc @klkvr