fix(trie): InMemoryTrieCursor case where all DB nodes are deleted#19464
Merged
mediocregopher merged 1 commit intomainfrom Nov 6, 2025
Merged
Conversation
Rjected
approved these changes
Nov 3, 2025
Member
Rjected
left a comment
There was a problem hiding this comment.
This makes sense to me, I wonder if, to make it more explicit, we should have an enum for cursor_entry, which would be:
enum CursorState {
/// Initial cursor state, when we haven't seeked, open to renames
Initial
/// The cursor is currently pointing to an entry.
Entry {
/// Path to the node
path: Nibbles,
/// The node
node: BranchNodeCompact,
},
/// The DB cursor is exhausted
Exhausted
}
yongkangc
pushed a commit
that referenced
this pull request
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was pointed out by @0x00101010 in a separate PR. Basically if the in-memory overlay completely deleted all nodes in the trie table, then there was no way to distinguish the cases of the db cursor being exhausted or having never been used; the
cursor_entryfield would beNonein both cases.