Skip to content

fix(engine): remove redundant parent_to_child cleanup in insert_executed #19380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fgimenez merged 1 commit into from
Oct 30, 2025
Merged

fix(engine): remove redundant parent_to_child cleanup in insert_executed #19380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions crates/engine/tree/src/tree/state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,6 @@ impl<N: NodePrimitives> TreeState<N> {
self.blocks_by_number.entry(block_number).or_default().push(executed);

self.parent_to_child.entry(parent_hash).or_default().insert(hash);

for children in self.parent_to_child.values_mut() {
children.retain(|child| self.blocks_by_hash.contains_key(child));
}
Comment on lines -111 to -113
Copy link
Copy Markdown
Collaborator

@mattsse mattsse Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, this really doesnt belong here and is kinda pointless here

}

/// Remove single executed block by its hash.
Expand Down