Skip to content

perf: optimize SyncHeight event handling to avoid recursive calls #19372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 6 commits into from
Oct 31, 2025
Merged

perf: optimize SyncHeight event handling to avoid recursive calls #19372

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f182f4e
Update sync_metrics.rs
DeVikingMark Oct 28, 2025
3c9e707
Update listener.rs
DeVikingMark Oct 28, 2025
e4b0509
Update listener.rs
DeVikingMark Oct 30, 2025
a3615d5
Update sync_metrics.rs
DeVikingMark Oct 30, 2025
dd5e5de
Update sync_metrics.rs
DeVikingMark Oct 30, 2025
2aafaee
chore: touchup
mattsse Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions crates/stages/api/src/metrics/listener.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,7 @@ impl MetricsListener {
trace!(target: "sync::metrics", ?event, "Metric event received");
match event {
MetricEvent::SyncHeight { height } => {
for stage_id in StageId::ALL {
self.handle_event(MetricEvent::StageCheckpoint {
stage_id,
checkpoint: StageCheckpoint {
block_number: height,
stage_checkpoint: None,
},
max_block_number: Some(height),
elapsed: Duration::default(),
});
}
self.update_all_stages_height(height);
}
MetricEvent::StageCheckpoint { stage_id, checkpoint, max_block_number, elapsed } => {
let stage_metrics = self.sync_metrics.get_stage_metrics(stage_id);
Expand All @@ -83,6 +73,17 @@ impl MetricsListener {
}
}
}

/// Updates all stage checkpoints to the given height efficiently.
fn update_all_stages_height(&mut self, height: BlockNumber) {
for stage_id in StageId::ALL {
let stage_metrics = self.sync_metrics.get_stage_metrics(stage_id);
let height_f64 = height as f64;
stage_metrics.checkpoint.set(height_f64);
stage_metrics.entities_processed.set(height_f64);
stage_metrics.entities_total.set(height_f64);
}
}
}

impl Future for MetricsListener {
Expand Down