feat(consensus): start with safe block hash#1932
Merged
rkrasiuk merged 1 commit intorkrasiuk/sync-controllerfrom Mar 23, 2023
Merged
feat(consensus): start with safe block hash#1932rkrasiuk merged 1 commit intorkrasiuk/sync-controllerfrom
rkrasiuk merged 1 commit intorkrasiuk/sync-controllerfrom
Conversation
mattsse
approved these changes
Mar 23, 2023
Comment on lines
142
to
143
rkrasiuk
force-pushed
the
rkrasiuk/start-with-safe-hash
branch
from
9b65c94 to
f39da52
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## rkrasiuk/sync-controller #1932 +/- ##
============================================================
- Coverage 73.34% 73.26% -0.08%
============================================================
Files 424 424
Lines 51750 51755 +5
============================================================
- Hits 37954 37920 -34
- Misses 13796 13835 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rkrasiuk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing change to #1845 as a PR, because it's mostly finalized.
Prefer
safe_block_hashas tip to start the sync from. Minimizes the chance of starting from reorged block and should increase the chance of finding good peers (especially on testnets).