Skip to content

refactor(engine): reorder multiproof.rs for organization#19314

Merged
mattsse merged 1 commit intoyk/reorder-proof-taskfrom
yk/reorder-multiproof
Oct 28, 2025
Merged

refactor(engine): reorder multiproof.rs for organization#19314
mattsse merged 1 commit intoyk/reorder-proof-taskfrom
yk/reorder-multiproof

Conversation

@yongkangc
Copy link
Member

@yongkangc yongkangc commented Oct 27, 2025

Part of #19182 - Stack of PRs for easier review
Depends on: #19313

Reorganizes multiproof.rs for a better flow:

  • Main API: ProofWorkerHandle, ProofTaskCtx, ProofTaskTx
  • Input Types: AccountMultiproofInput, StorageProofInput
  • Result Types: ProofResultMessage, ProofResultContext, ProofResult
  • Provider Types: ProofTaskTrieNodeProvider
  • Internal Types: Worker job enums and parameter structs

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Oct 27, 2025
@yongkangc yongkangc self-assigned this Oct 27, 2025
@yongkangc yongkangc changed the title refactor(engine): reorder multiproof.rs for better code organization refactor(engine): reorder multiproof.rs for organization Oct 27, 2025
@yongkangc yongkangc requested a review from shekhirin October 27, 2025 10:02
@yongkangc yongkangc marked this pull request as ready for review October 27, 2025 10:02
Reorganizes multiproof.rs to follow Rust file organization conventions:
1. Public types first (SparseTrieUpdate, MultiproofInput)
2. MultiproofManager and its implementation
3. MultiProofTask and its implementation
4. Helper functions

No logic changes - pure code organization for improved readability.
Main public types are now at the top, making it easier to understand
the module's interface at a glance.

Part of #19182
Depends on: #19313
@yongkangc yongkangc force-pushed the yk/reorder-multiproof branch from 4c15de6 to 6a6ad3f Compare October 27, 2025 10:11
@yongkangc yongkangc force-pushed the yk/reorder-proof-task branch from ad1cb0a to 68c6079 Compare October 27, 2025 10:11
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Oct 28, 2025
@mattsse mattsse merged commit 6636c6b into yk/reorder-proof-task Oct 28, 2025
73 checks passed
@mattsse mattsse deleted the yk/reorder-multiproof branch October 28, 2025 09:44
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Oct 28, 2025
@jenpaff jenpaff moved this from Done to Completed in Reth Tracker Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

2 participants