Skip to content

fix(node): remove unused ConsensusLayerHealthEvent variants #19238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 4 commits into from
Oct 22, 2025
Merged

fix(node): remove unused ConsensusLayerHealthEvent variants #19238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5952f33
fix: remove unused ConsensusLayerHealthEvent variants
radik878 Oct 22, 2025
e38eaf3
Update cl.rs
radik878 Oct 22, 2025
3f91522
Update cl.rs
radik878 Oct 22, 2025
388a649
Update node.rs
radik878 Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions crates/node/events/src/cl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ impl<H: Send + Sync> Stream for ConsensusLayerHealthEvents<H> {
))
}

// We never had both FCU and transition config exchange.
// We never received any forkchoice updates.
return Poll::Ready(Some(ConsensusLayerHealthEvent::NeverSeen))
}
}
Expand All @@ -71,12 +71,8 @@ impl<H: Send + Sync> Stream for ConsensusLayerHealthEvents<H> {
/// Execution Layer point of view.
#[derive(Clone, Copy, Debug)]
pub enum ConsensusLayerHealthEvent {
/// Consensus Layer client was never seen.
/// Consensus Layer client was never seen (no forkchoice updates received).
NeverSeen,
/// Consensus Layer client has not been seen for a while.
HasNotBeenSeenForAWhile(Duration),
/// Updates from the Consensus Layer client were never received.
NeverReceivedUpdates,
/// Updates from the Consensus Layer client have not been received for a while.
/// Forkchoice updates from the Consensus Layer client have not been received for a while.
HaveNotReceivedUpdatesForAWhile(Duration),
}
11 changes: 0 additions & 11 deletions crates/node/events/src/node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,17 +296,6 @@ impl NodeState {
"Post-merge network, but never seen beacon client. Please launch one to follow the chain!"
)
}
ConsensusLayerHealthEvent::HasNotBeenSeenForAWhile(period) => {
warn!(
?period,
"Post-merge network, but no beacon client seen for a while. Please launch one to follow the chain!"
)
}
ConsensusLayerHealthEvent::NeverReceivedUpdates => {
warn!(
"Beacon client online, but never received consensus updates. Please ensure your beacon client is operational to follow the chain!"
)
}
ConsensusLayerHealthEvent::HaveNotReceivedUpdatesForAWhile(period) => {
warn!(
?period,
Expand Down
Loading