perf: reuse transaction cursor and batch fetch block indices in Transactions segment (no mapping)#19200
Closed
aleexeyy wants to merge 2 commits intoparadigmxyz:mainfrom
Closed
Conversation
Member
|
We decided to remove the transactions segment altogether, as it's unused now #19209 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the same issue as #19079, but corrects a misunderstanding from my previous PR.
In my first PR (#19196) I explicitly mapped
BlockBodyIndicestoBlockNumbers, thinking it was necessary to preserve the mapping. After further investigation, it turns out this is unnecessary, because theblock_body_indices_rangemethod already returns indices sequentially and stops at the first missing block. Therefore, we can implement the optimization without introducing a new API method.Note: I have a concern about using
usizeto enumerate au64..u64range. On 32-bit systems, if the range is very large, it could potentially overflow. I need to get your opinion on that, maybe I am wrong.Changes in this PR
Transactionssegment.Expected Benefits
References