feat(net): mplement disconnect handling in ProtocolProxy via control channel#19158
Closed
radik878 wants to merge 1 commit intoparadigmxyz:mainfrom
Closed
feat(net): mplement disconnect handling in ProtocolProxy via control channel#19158radik878 wants to merge 1 commit intoparadigmxyz:mainfrom
radik878 wants to merge 1 commit intoparadigmxyz:mainfrom
Conversation
mattsse
reviewed
Oct 23, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
I think not having this is fine because if the stream is terminated this would trigger a disconnect anyway
Contributor
Author
could i remove todo then or leave it as is is fine? |
Collaborator
|
I'm okay with removing the todo yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented CanDisconnect for ProtocolProxy by adding a dedicated disconnect control channel to signal the underlying P2PStream.
Hooked the disconnect signal into both the handshake loop and RlpxSatelliteStream::poll_next, invoking start_disconnect on the connection.
.