Skip to content

fix(prune): Disable pruning limits #19141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mediocregopher merged 4 commits into from
Oct 20, 2025
Merged

fix(prune): Disable pruning limits #19141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0387e01
fix(prune): Disable pruning limits
mediocregopher Oct 20, 2025
41e6fcf
Fix default PrunerBuilder
mediocregopher Oct 20, 2025
22020ea
chainspec
mediocregopher Oct 20, 2025
d28c9cc
lock
mediocregopher Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions crates/node/builder/src/launch/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,8 +421,6 @@ impl<R, ChainSpec: EthChainSpec> LaunchContextWith<Attached<WithConfigs<ChainSpe
ChainSpec: reth_chainspec::EthereumHardforks,
{
PrunerBuilder::new(self.prune_config().unwrap_or_default())
.delete_limit(self.chain_spec().prune_delete_limit())
.timeout(PrunerBuilder::DEFAULT_TIMEOUT)
}

/// Loads the JWT secret for the engine API
Expand Down
1 change: 0 additions & 1 deletion crates/prune/prune/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ workspace = true

[dependencies]
# reth
reth-chainspec.workspace = true
reth-exex-types.workspace = true
reth-db-api.workspace = true
reth-errors.workspace = true
Expand Down
6 changes: 1 addition & 5 deletions crates/prune/prune/src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
use crate::{segments::SegmentSet, Pruner};
use alloy_eips::eip2718::Encodable2718;
use reth_chainspec::MAINNET_PRUNE_DELETE_LIMIT;
use reth_config::PruneConfig;
use reth_db_api::{table::Value, transaction::DbTxMut};
use reth_exex_types::FinishedExExHeight;
Expand Down Expand Up @@ -30,9 +29,6 @@ pub struct PrunerBuilder {
}

impl PrunerBuilder {
/// Default timeout for a prune run.
pub const DEFAULT_TIMEOUT: Duration = Duration::from_millis(100);

/// Creates a new [`PrunerBuilder`] from the given [`PruneConfig`].
pub fn new(pruner_config: PruneConfig) -> Self {
Self::default()
Expand Down Expand Up @@ -135,7 +131,7 @@ impl Default for PrunerBuilder {
Self {
block_interval: 5,
segments: PruneModes::default(),
delete_limit: MAINNET_PRUNE_DELETE_LIMIT,
delete_limit: usize::MAX,
timeout: None,
finished_exex_height: watch::channel(FinishedExExHeight::NoExExs).1,
}
Expand Down
Loading