Skip to content

fix(cli): Remove duplicit static file header and transaction append#19103

Merged
mattsse merged 1 commit intomainfrom
init-ronin-state
Oct 17, 2025
Merged

fix(cli): Remove duplicit static file header and transaction append#19103
mattsse merged 1 commit intomainfrom
init-ronin-state

Conversation

@RomanHodulak
Copy link
Contributor

@RomanHodulak RomanHodulak commented Oct 17, 2025 •
edited by mattsse
Loading

Fixes an import bug, in which this command fails.

reth init-state ./dump.json --datadir=test --chain ./chainspec.json --header=./header.rlp --header-hash=0x4f05e4392969fc82e41f6d6a8cea379323b0b2d3ddf7def1a33eec03883e3a33 --total-difficulty=0 --without-evm

By reporting

2025-10-16T15:42:50.687043Z  INFO Appending first valid block.
Error: trying to append data to Headers as block #1700 but expected block #1701

@RomanHodulak RomanHodulak requested a review from mattsse as a code owner October 17, 2025 07:14
@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Oct 17, 2025
mattsse
mattsse approved these changes Oct 17, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah this makes sense

I believe this happened after we moved headers entire to static files

can we add an e2e test with those commands to ensure we keep this working?

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Oct 17, 2025
@RomanHodulak RomanHodulak requested a review from gakonst as a code owner October 17, 2025 07:52
@mattsse mattsse added the C-bug An unexpected or incorrect behavior label Oct 17, 2025
@mattsse mattsse added this pull request to the merge queue Oct 17, 2025
Merged via the queue into main with commit 73af300 Oct 17, 2025
39 of 40 checks passed
@mattsse mattsse deleted the init-ronin-state branch October 17, 2025 09:02
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Oct 17, 2025
@jenpaff jenpaff added this to the v1.8.3 milestone Oct 17, 2025
emhane pushed a commit to op-rs/op-reth that referenced this pull request Oct 20, 2025
@RomanHodulak @emhane
fix(cli): Remove duplicit static file header and transaction append (p…
62658f6 
…aradigmxyz#19103)
emhane pushed a commit to op-rs/op-reth that referenced this pull request Oct 20, 2025
@RomanHodulak @emhane
fix(cli): Remove duplicit static file header and transaction append (p…
8f0c6c7 
…aradigmxyz#19103)
@jenpaff jenpaff moved this from Done to Completed in Reth Tracker Oct 30, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 22, 2026
@RomanHodulak
fix(cli): Remove duplicit static file header and transaction append (p…
ac05846 
…aradigmxyz/reth#19103)
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Feb 11, 2026
@RomanHodulak
fix(cli): Remove duplicit static file header and transaction append (p…
3e1e816 
…aradigmxyz/reth#19103)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees

@RomanHodulak RomanHodulak

Labels

C-bug An unexpected or incorrect behavior

Projects

Reth Tracker
Status: Completed

Milestone

v1.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@RomanHodulak @mattsse @jenpaff