Skip to content

refactor: naming fix for multiproof dispatch #19102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mediocregopher merged 3 commits into from
Oct 17, 2025
Merged

refactor: naming fix for multiproof dispatch #19102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3306179
refactor: naming fix
yongkangc Oct 17, 2025
4ba880f
compile
yongkangc Oct 17, 2025
77e1a17
refactor(trie): make dispatch functions public and update documentation
yongkangc Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/trie/parallel/src/proof.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ impl ParallelProof {
);

self.proof_worker_handle
.queue_storage_proof(input)
.dispatch_storage_proof(input)
.map_err(|e| ParallelStateRootError::Other(e.to_string()))
}

Expand Down
16 changes: 8 additions & 8 deletions crates/trie/parallel/src/proof_task.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,8 +958,8 @@ impl ProofWorkerHandle {
Self { storage_work_tx, account_work_tx }
}

/// Queue a storage proof computation
pub fn queue_storage_proof(
/// Dispatch a storage proof computation to storage worker pool
pub fn dispatch_storage_proof(
&self,
input: StorageProofInput,
) -> Result<Receiver<StorageProofResult>, ProviderError> {
Expand Down Expand Up @@ -988,8 +988,8 @@ impl ProofWorkerHandle {
Ok(rx)
}

/// Internal: Queue blinded storage node request
fn queue_blinded_storage_node(
/// Dispatch blinded storage node request to storage worker pool
pub(crate) fn dispatch_blinded_storage_node(
&self,
account: B256,
path: Nibbles,
Expand All @@ -1004,8 +1004,8 @@ impl ProofWorkerHandle {
Ok(rx)
}

/// Internal: Queue blinded account node request
fn queue_blinded_account_node(
/// Dispatch blinded account node request to account worker pool
pub(crate) fn dispatch_blinded_account_node(
&self,
path: Nibbles,
) -> Result<Receiver<TrieNodeProviderResult>, ProviderError> {
Expand Down Expand Up @@ -1055,13 +1055,13 @@ impl TrieNodeProvider for ProofTaskTrieNodeProvider {
match self {
Self::AccountNode { handle } => {
let rx = handle
.queue_blinded_account_node(*path)
.dispatch_blinded_account_node(*path)
.map_err(|error| SparseTrieErrorKind::Other(Box::new(error)))?;
rx.recv().map_err(|error| SparseTrieErrorKind::Other(Box::new(error)))?
}
Self::StorageNode { handle, account } => {
let rx = handle
.queue_blinded_storage_node(*account, *path)
.dispatch_blinded_storage_node(*account, *path)
.map_err(|error| SparseTrieErrorKind::Other(Box::new(error)))?;
rx.recv().map_err(|error| SparseTrieErrorKind::Other(Box::new(error)))?
}
Expand Down
Loading