Skip to content

fix: support rlp hex in read_header_from_file#19089

Merged
mattsse merged 2 commits intomainfrom
mattsse/test-read-header-from-file
Oct 16, 2025
Merged

fix: support rlp hex in read_header_from_file#19089
mattsse merged 2 commits intomainfrom
mattsse/test-read-header-from-file

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 16, 2025

this would fail if the file content is hex rlp

this now supports both variants

Copy link
Contributor

@RomanHodulak RomanHodulak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Oct 16, 2025
@mattsse mattsse requested a review from gakonst as a code owner October 16, 2025 14:10
@mattsse mattsse enabled auto-merge October 16, 2025 14:11
@mattsse mattsse added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit ff2236e Oct 16, 2025
40 of 41 checks passed
@mattsse mattsse deleted the mattsse/test-read-header-from-file branch October 16, 2025 14:42
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Oct 16, 2025
emhane pushed a commit to op-rs/op-reth that referenced this pull request Oct 20, 2025
emhane pushed a commit to op-rs/op-reth that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants