fix(session): remove Clone derive from SessionCounter#19051
Merged
mattsse merged 1 commit intoparadigmxyz:mainfrom Oct 15, 2025
Merged
fix(session): remove Clone derive from SessionCounter#19051mattsse merged 1 commit intoparadigmxyz:mainfrom
mattsse merged 1 commit intoparadigmxyz:mainfrom
Conversation
emhane
pushed a commit
to op-rs/op-reth
that referenced
this pull request
Oct 20, 2025
emhane
pushed a commit
to op-rs/op-reth
that referenced
this pull request
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Clone from SessionCounter to prevent accidental duplication of mutable state. SessionCounter tracks live counters within SessionManager and is not cloned anywhere; keeping Clone is a footgun that could lead to diverging metrics if copies are modified independently. For cloneable counters we use Arc-based wrappers (see DisconnectionsCounter); SessionCounter should remain non-clone to reflect its ownership and mutation model.