feat: use env filter for otlp, respect otel env var#19050
Merged
Conversation
Collaborator
prestwich
commented
Oct 15, 2025
prestwich
commented
- enhance the OTLP args by allowing a full env filter
- Note: this is backwards compatible, as all levels are also valid filter directives
- allow lazy url specification by setting the path if the path is unset
- respect OTEL conventions by allowing the url to be set via the standard env var for trace exporting
- improve documentation
prestwich
requested review from
Rjected,
gakonst,
klkvr and
mattsse
as code owners
Collaborator
Author
|
what's the thing to update the book again? |
Collaborator
|
@prestwich it's |
mattsse
reviewed
Oct 15, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this does make sense but would appreciate another review from @Rjected or @shekhirin
cc @lean-apple for vis
Rjected
approved these changes
Oct 15, 2025
Member
Rjected
left a comment
Rjected
left a comment
There was a problem hiding this comment.
ty, the env filter is much more flexible, and env var makes sense
emhane
pushed a commit
to op-rs/op-reth
that referenced
this pull request
Oct 20, 2025
emhane
pushed a commit
to op-rs/op-reth
that referenced
this pull request
Oct 20, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.