Skip to content

fix: unused warnings for tracing #19025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 1 commit into from
Oct 15, 2025
Merged

fix: unused warnings for tracing #19025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/tracing/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ tracing-logfmt.workspace = true
clap = { workspace = true, features = ["derive"] }
eyre.workspace = true
rolling-file.workspace = true
url.workspace = true
url = { workspace = true, optional = true }

[features]
default = ["otlp"]
otlp = ["reth-tracing-otlp"]
otlp = ["reth-tracing-otlp", "dep:url"]
6 changes: 2 additions & 4 deletions crates/tracing/src/layers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@ use std::{
fmt,
path::{Path, PathBuf},
};
use tracing::level_filters::LevelFilter;
use tracing_appender::non_blocking::WorkerGuard;
use tracing_subscriber::{filter::Directive, EnvFilter, Layer, Registry};
use url::Url;

/// A worker guard returned by the file layer.
///
Expand Down Expand Up @@ -131,14 +129,14 @@ impl Layers {
pub fn with_span_layer(
&mut self,
service_name: String,
endpoint_exporter: Url,
endpoint_exporter: url::Url,
level: tracing::Level,
) -> eyre::Result<()> {
// Create the span provider

let span_layer = span_layer(service_name, &endpoint_exporter)
.map_err(|e| eyre::eyre!("Failed to build OTLP span exporter {}", e))?
.with_filter(LevelFilter::from_level(level));
.with_filter(tracing::level_filters::LevelFilter::from_level(level));

self.add_layer(span_layer);

Expand Down
Loading