refactor(prune): Decouple interface and implementation#19023
Closed
RomanHodulak wants to merge 5 commits intomainfrom
Closed
refactor(prune): Decouple interface and implementation#19023RomanHodulak wants to merge 5 commits intomainfrom
RomanHodulak wants to merge 5 commits intomainfrom
Conversation
RomanHodulak
force-pushed
the
prune-mdbx
branch
from
56af029 to
ca523e8
Compare
RomanHodulak
requested review from
DaniPopes,
Rjected,
gakonst,
joshieDo,
klkvr,
mattsse,
mediocregopher,
rkrasiuk and
shekhirin
as code owners
RomanHodulak
force-pushed
the
prune-mdbx
branch
2 times, most recently
from
2f69997 to
e0d3e75
Compare
Member
|
@RomanHodulak I feel like Also looks like there some merge conflicts that need to be resolved |
RomanHodulak
force-pushed
the
prune-mdbx
branch
from
e0d3e75 to
d50a1f0
Compare
joshieDo
approved these changes
Oct 22, 2025
Contributor
Author
|
I think I'll chop this up into smaller steps, as this keeps getting out of sync and is hard to review. Starting with #19232 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #18926
Kicking off the pruner refactor is the PR that separates all the interfaces and implementation for the existing database.