Skip to content

feat: add metrics for safe and finalized block heights #18987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yongkangc merged 1 commit into from
Oct 15, 2025
Merged

feat: add metrics for safe and finalized block heights #18987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/engine/tree/src/tree/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,10 @@ pub(crate) struct TreeMetrics {
pub reorgs: Counter,
/// The latest reorg depth
pub latest_reorg_depth: Gauge,
/// The current safe block height (this is required by optimism)
pub safe_block_height: Gauge,
/// The current finalized block height (this is required by optimism)
pub finalized_block_height: Gauge,
}

/// Metrics for the `EngineApi`.
Expand Down
8 changes: 6 additions & 2 deletions crates/engine/tree/src/tree/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2805,7 +2805,9 @@ where
// we're also persisting the finalized block on disk so we can reload it on
// restart this is required by optimism which queries the finalized block: <https://github.com/ethereum-optimism/optimism/blob/c383eb880f307caa3ca41010ec10f30f08396b2e/op-node/rollup/sync/start.go#L65-L65>
let _ = self.persistence.save_finalized_block_number(finalized.number());
self.canonical_in_memory_state.set_finalized(finalized);
self.canonical_in_memory_state.set_finalized(finalized.clone());
// Update finalized block height metric
self.metrics.tree.finalized_block_height.set(finalized.number() as f64);
}
}
Err(err) => {
Expand Down Expand Up @@ -2833,7 +2835,9 @@ where
// we're also persisting the safe block on disk so we can reload it on
// restart this is required by optimism which queries the safe block: <https://github.com/ethereum-optimism/optimism/blob/c383eb880f307caa3ca41010ec10f30f08396b2e/op-node/rollup/sync/start.go#L65-L65>
let _ = self.persistence.save_safe_block_number(safe.number());
self.canonical_in_memory_state.set_safe(safe);
self.canonical_in_memory_state.set_safe(safe.clone());
// Update safe block height metric
self.metrics.tree.safe_block_height.set(safe.number() as f64);
}
}
Err(err) => {
Expand Down
Loading