feat: Use generic HeaderTy for reth db get static-file headers#18870
Merged
shekhirin merged 1 commit intoparadigmxyz:mainfrom Oct 6, 2025
Merged
feat: Use generic HeaderTy for reth db get static-file headers#18870shekhirin merged 1 commit intoparadigmxyz:mainfrom
HeaderTy for reth db get static-file headers#18870shekhirin merged 1 commit intoparadigmxyz:mainfrom
Conversation
sprites0
added a commit
to hl-archive-node/reth
that referenced
this pull request
Oct 9, 2025
…aradigmxyz#18870) Co-authored-by: sprites0 <199826320+sprites0@users.noreply.github.com>
CarlBeek
added a commit
to CarlBeek/reth
that referenced
this pull request
Oct 10, 2025
* main: (280 commits) refactor: remove needless collect() calls in trie tests (paradigmxyz#18937) chore(grafana): use precompile address as legend (paradigmxyz#18913) perf(tree): worker pooling for storage in multiproof generation (paradigmxyz#18887) feat: wait for new blocks when build is in progress (paradigmxyz#18831) chore: align node_config threshold constant (paradigmxyz#18914) docs: duplicate comment in Eip4844PoolTransactionError (paradigmxyz#18858) ci: cache hive simulator images to reduce prepare-hive job time (paradigmxyz#18899) refactor: replace collect().is_empty() with next().is_none() in tests (paradigmxyz#18902) feat(provider): add get_account_before_block to ChangesetReader (paradigmxyz#18898) refactor(engine): separate concerns in on_forkchoice_updated for better maintainability (paradigmxyz#18661) chore(node): simplify EngineApiExt bounds by removing redundant constraints (paradigmxyz#18905) fix(trie): Reveal extension child when extension is last remaining child of a branch (paradigmxyz#18891) chore: make clippy happy (paradigmxyz#18900) chore: relax `ChainSpec` impls (paradigmxyz#18894) refactor: eliminate redundant allocation in precompile cache example (paradigmxyz#18886) fix(era-utils): fix off-by-one for Excluded end bound in process_iter (paradigmxyz#18731) docs: yellowpaper sections in consensus implementation (paradigmxyz#18881) feat(storage): read headers and transactions only from static files (paradigmxyz#18788) feat: Use generic `HeaderTy` for `reth db get static-file headers` (paradigmxyz#18870) fix: streamline payload conversion in custom engine API (paradigmxyz#18864) ...
theochap
pushed a commit
to theochap/reth
that referenced
this pull request
Oct 13, 2025
…aradigmxyz#18870) Co-authored-by: sprites0 <199826320+sprites0@users.noreply.github.com>
mattsse
pushed a commit
that referenced
this pull request
Oct 14, 2025
…18870) Co-authored-by: sprites0 <199826320+sprites0@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for custom headers in the
reth db get static-file headers <N>command, to make it more consistent with other parts ofStaticFileProviderRWwhich uses NodePrimitives::BlockHeader.Motivation
This patch is particularly relevant for NodeBuilder API usages e.g., reth-hl, which will rely on a custom header type with a dedicated
Compacttrait implementation.Example output