Skip to content

refactor(engine): simplify InvalidBlockWitnessHook::on_invalid_block for better testability #18696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yongkangc merged 11 commits into from
Oct 15, 2025
Merged

refactor(engine): simplify InvalidBlockWitnessHook::on_invalid_block for better testability #18696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bfb2f62
Resolve lint warnings
0xKarl98 Oct 13, 2025
17d25b7
Restore previous changes
0xKarl98 Oct 13, 2025
c7f5afd
resolve errors
0xKarl98 Oct 13, 2025
67c6f90
fix: remove commits_history.txt file with typos
0xKarl98 Oct 13, 2025
1919e5b
fix: resolve witness.rs syntax error and restore dependencies
0xKarl98 Oct 13, 2025
92da536
Resolve errors
0xKarl98 Oct 13, 2025
3fc8290
Resolve lint errors
0xKarl98 Oct 13, 2025
2472366
Fix falure lint jobs
0xKarl98 Oct 13, 2025
ff5dfdd
git pull
0xKarl98 Oct 13, 2025
b8a97b6
trigger CI re-run
0xKarl98 Oct 13, 2025
cff4346
Remove unnecessary exclude_crates
0xKarl98 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions crates/engine/invalid-block-hooks/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ workspace = true

[dependencies]
# reth
revm.workspace = true
revm-bytecode.workspace = true
revm-database.workspace = true
reth-engine-primitives.workspace = true
Expand All @@ -38,3 +39,13 @@ jsonrpsee.workspace = true
pretty_assertions.workspace = true
serde.workspace = true
serde_json.workspace = true

[dev-dependencies]
alloy-eips.workspace = true
reth-chainspec.workspace = true
reth-ethereum-primitives.workspace = true
reth-evm-ethereum.workspace = true
reth-provider = { workspace = true, features = ["test-utils"] }
reth-revm = { workspace = true, features = ["test-utils"] }
reth-testing-utils.workspace = true
tempfile.workspace = true
Loading
Loading