fix(engine): remove redundant parent_to_child removal during eviction

[Forostovec]

• Drop duplicate remove_from_parent call in insert_block eviction path; remove_block already handles it.
• No functional changes; micro-optimization and slight simplification.
• Tests and metrics unaffected; eviction remains FIFO via block_queue.

[mattsse]

lgtm

but would like a sanity check from @yongkangc or @shekhirin perhaps

[mattsse]

this is indeed redundant here

reth/crates/engine/tree/src/tree/block_buffer.rs

Lines 152 to 155 in 9856712

	fn remove_block(&mut self, hash: &BlockHash) -> Option<RecoveredBlock<B>> {
	let block = self.blocks.remove(hash)?;
	self.remove_from_earliest_blocks(block.number(), hash);
	self.remove_from_parent(block.parent_hash(), hash);

[yongkangc]

generally looks ok to me

would be nice to maybe add test for parent-child cleanup is properly maintained during eviction during eviction?

[Forostovec]

generally looks ok to me

would be nice to maybe add test for parent-child cleanup is properly maintained during eviction during eviction?

added test

[yongkangc]

sending