chore(observability): add tokio runtime with custom thread naming#18623
Merged
chore(observability): add tokio runtime with custom thread naming#18623
Conversation
- better observability, similar to how we doin it on rayon - The fetch_add happens only while each worker thread is being spawned, so it runs a handful of times during startup—not per task. here, with one call per thread creation, it’s essentially free compared with the cost of launching the thread itself.
… tokio runtime - Introduced an AtomicUsize to track and name threads in the tokio runtime, enhancing observability during thread creation. - The thread naming function utilizes fetch_add to ensure unique identifiers for each worker thread, improving clarity in logs.
yongkangc
added
the
A-observability
- Updated the thread naming function to format thread names for better observability, aligning with the custom naming approach used in the tokio runtime. - Introduced atomic operations to ensure unique thread identifiers during creation, improving clarity in logs.
yongkangc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #18624 - All threads looked identical - impossible to debug or profile
Changes:
reth-cli-tokio-{id}(e.g.,reth-cli-tokio-0,reth-cli-tokio-1)reth-wkpool-tokio-{id}(e.g.,reth-wkpool-tokio-0,reth-wkpool-tokio-1)reth-trie-tokio-{id}(e.g.,reth-trie-tokio-0,reth-trie-tokio-1)reth-blocking-rayon-{id}(e.g.,reth-blocking-rayon-0,reth-blocking-rayon-1)reth-rayon-{id}(e.g.,reth-rayon-0,reth-rayon-1)