feat: support block number in required-block-hashes parameter#18546
Merged
mattsse merged 5 commits intoparadigmxyz:mainfrom Nov 12, 2025
Merged
feat: support block number in required-block-hashes parameter#18546mattsse merged 5 commits intoparadigmxyz:mainfrom
mattsse merged 5 commits intoparadigmxyz:mainfrom
Conversation
Peponks9
reviewed
Sep 24, 2025
Contributor
Peponks9
left a comment
Peponks9
left a comment
There was a problem hiding this comment.
hey, try to add Closes #number_of_issue to the description so this pr will be linked to the issue. might tell the maintainers to check soon :)
Contributor
Author
Thanks for the advice!!!!!! |
Contributor
Author
github-actions
bot
added
the
S-stale
Contributor
Author
|
@mattsse Hi boss, closed by bots, would you please re-open this? |
Collaborator
|
sorry @leniram159 forgot to review this in time, we still want this, thanks for the ping |
github-actions
bot
removed
the
S-stale
mattsse
approved these changes
Nov 12, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
lgtm
sorry forgot about this one
emhane
pushed a commit
to op-rs/op-reth
that referenced
this pull request
Nov 24, 2025
…gmxyz#18546) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements support for block number in the
--required-block-hashesparameter as requested in issue #18543.BlockNumHashinstead ofB256for required block hashesblock_number=hashformat (e.g.,23115201=0x1234...)