Skip to content

fix: add missing StructLog fields#1847

Merged
gakonst merged 2 commits intomainfrom
matt/add-missing-structlog-fields
Mar 19, 2023
Merged

fix: add missing StructLog fields#1847
gakonst merged 2 commits intomainfrom
matt/add-missing-structlog-fields

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 19, 2023

the structlog object captures additional values

adds missing fields such as memoryLimit, and returnData (output of last CALL)

https://geth.ethereum.org/docs/developers/evm-tracing/built-in-tracers

@mattsse mattsse requested a review from gakonst as a code owner March 19, 2023 18:47
@mattsse mattsse added the A-rpc Related to the RPC implementation label Mar 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2023

Codecov Report

Merging #1847 (fd463f5) into main (0936523) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1847      +/-   ##
==========================================
- Coverage   73.41%   73.41%   -0.01%     
==========================================
  Files         415      415              
  Lines       50545    50555      +10     
==========================================
+ Hits        37109    37113       +4     
- Misses      13436    13442       +6     
Flag Coverage Δ
integration-tests 19.68% <0.00%> (-0.03%) ⬇️
unit-tests 67.69% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/revm/revm-inspectors/src/tracing/builder/geth.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/mod.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/types.rs 0.00% <0.00%> (ø)
crates/rpc/rpc-types/src/eth/trace/geth/mod.rs 12.28% <ø> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mattsse mattsse force-pushed the matt/add-missing-structlog-fields branch from fd463f5 to b74d88b Compare March 19, 2023 19:15
@gakonst gakonst merged commit a59806f into main Mar 19, 2023
@gakonst gakonst deleted the matt/add-missing-structlog-fields branch March 19, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants