Skip to content

chore(pipeline): expose TestStage and add test stage set#1844

Merged
rkrasiuk merged 1 commit intomainfrom
rkrasiuk/test-utils-stage-and-set
Mar 19, 2023
Merged

chore(pipeline): expose TestStage and add test stage set#1844
rkrasiuk merged 1 commit intomainfrom
rkrasiuk/test-utils-stage-and-set

Conversation

@rkrasiuk
Copy link
Contributor

Ref #1662

@rkrasiuk rkrasiuk added A-staged-sync Related to staged sync (pipelines and stages) C-test A change that impacts how or what we test labels Mar 19, 2023
@rkrasiuk rkrasiuk requested a review from mattsse March 19, 2023 15:21
@rkrasiuk rkrasiuk requested a review from onbjerg as a code owner March 19, 2023 15:21
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this moves types from nester mod to standalone module so it can be reused.

lgtm

@rkrasiuk rkrasiuk force-pushed the rkrasiuk/test-utils-stage-and-set branch from 111200d to 3e3493c Compare March 19, 2023 15:25
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/test-utils-stage-and-set branch from 3e3493c to 3b70c7d Compare March 19, 2023 15:28
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2023

Codecov Report

Merging #1844 (3b70c7d) into main (6bb341a) will decrease coverage by 0.02%.
The diff coverage is 55.93%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1844      +/-   ##
==========================================
- Coverage   73.53%   73.52%   -0.02%     
==========================================
  Files         410      415       +5     
  Lines       50497    50469      -28     
==========================================
- Hits        37133    37107      -26     
+ Misses      13364    13362       -2     
Flag Coverage Δ
integration-tests 19.73% <0.00%> (+<0.01%) ⬆️
unit-tests 67.86% <55.93%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/stages/src/test_utils/set.rs 0.00% <0.00%> (ø)
crates/stages/src/test_utils/stage.rs 72.72% <72.72%> (ø)
crates/stages/src/pipeline/mod.rs 84.23% <100.00%> (-2.20%) ⬇️

... and 24 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rkrasiuk rkrasiuk merged commit 0128d42 into main Mar 19, 2023
@rkrasiuk rkrasiuk deleted the rkrasiuk/test-utils-stage-and-set branch March 19, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-staged-sync Related to staged sync (pipelines and stages) C-test A change that impacts how or what we test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants