Skip to content

chore(pipeline): extract helper types to separate files#1842

Merged
rkrasiuk merged 1 commit intomainfrom
rkrasiuk/cleanup-pipeline-types
Mar 19, 2023
Merged

chore(pipeline): extract helper types to separate files#1842
rkrasiuk merged 1 commit intomainfrom
rkrasiuk/cleanup-pipeline-types

Conversation

@rkrasiuk
Copy link
Contributor

Ref #1662
Extract helper types to separate files

@rkrasiuk rkrasiuk added A-staged-sync Related to staged sync (pipelines and stages) C-debt A clean up/refactor of existing code labels Mar 19, 2023
@rkrasiuk rkrasiuk requested a review from mattsse March 19, 2023 14:17
@rkrasiuk rkrasiuk requested a review from onbjerg as a code owner March 19, 2023 14:17
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2023

Codecov Report

Merging #1842 (360812b) into main (25ac137) will decrease coverage by 0.04%.
The diff coverage is 96.15%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1842      +/-   ##
==========================================
- Coverage   73.58%   73.54%   -0.04%     
==========================================
  Files         409      411       +2     
  Lines       50438    50438              
==========================================
- Hits        37116    37097      -19     
- Misses      13322    13341      +19     
Flag Coverage Δ
integration-tests 19.75% <0.00%> (+0.01%) ⬆️
unit-tests 67.90% <96.15%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/stages/src/pipeline/mod.rs 85.33% <ø> (-0.59%) ⬇️
crates/stages/src/pipeline/sync_metrics.rs 90.00% <90.00%> (ø)
crates/stages/src/pipeline/progress.rs 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rkrasiuk rkrasiuk merged commit 274ab54 into main Mar 19, 2023
@rkrasiuk rkrasiuk deleted the rkrasiuk/cleanup-pipeline-types branch March 19, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-staged-sync Related to staged sync (pipelines and stages) C-debt A clean up/refactor of existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants