Skip to content

chore(executor): extract test utils#1841

Merged
rkrasiuk merged 1 commit intomainfrom
rkrasiuk/executor-test-utils
Mar 19, 2023
Merged

chore(executor): extract test utils#1841
rkrasiuk merged 1 commit intomainfrom
rkrasiuk/executor-test-utils

Conversation

@rkrasiuk
Copy link
Contributor

Ref #1662
Extract executor test utilities and put them behind a feature flag

@rkrasiuk rkrasiuk added C-debt A clean up/refactor of existing code A-execution Related to the Execution and EVM labels Mar 19, 2023
@rkrasiuk rkrasiuk requested a review from mattsse March 19, 2023 14:12
@rkrasiuk rkrasiuk requested a review from rakita as a code owner March 19, 2023 14:12
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2023

Codecov Report

Merging #1841 (0d418fa) into main (25ac137) will decrease coverage by 0.05%.
The diff coverage is 62.50%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1841      +/-   ##
==========================================
- Coverage   73.58%   73.53%   -0.05%     
==========================================
  Files         409      411       +2     
  Lines       50438    50438              
==========================================
- Hits        37116    37092      -24     
- Misses      13322    13346      +24     
Flag Coverage Δ
integration-tests 19.70% <0.00%> (-0.03%) ⬇️
unit-tests 67.88% <62.50%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/executor/src/lib.rs 100.00% <ø> (ø)
crates/executor/src/test_utils/executor.rs 50.00% <50.00%> (ø)
crates/executor/src/test_utils/factory.rs 71.42% <71.42%> (ø)
crates/executor/src/blockchain_tree/mod.rs 92.53% <100.00%> (+1.64%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rkrasiuk rkrasiuk merged commit 02cb1e3 into main Mar 19, 2023
@rkrasiuk rkrasiuk deleted the rkrasiuk/executor-test-utils branch March 19, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-execution Related to the Execution and EVM C-debt A clean up/refactor of existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants