Skip to content

chore(rpc): rm allow unused#1838

Merged
mattsse merged 1 commit intomainfrom
matt/cleanup-builder
Mar 19, 2023
Merged

chore(rpc): rm allow unused#1838
mattsse merged 1 commit intomainfrom
matt/cleanup-builder

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 19, 2023

rm outdated lint and apply fixes.

@mattsse mattsse requested a review from gakonst as a code owner March 19, 2023 12:55
@mattsse mattsse requested review from Rjected and rkrasiuk March 19, 2023 12:55
@mattsse mattsse added C-debt A clean up/refactor of existing code A-rpc Related to the RPC implementation labels Mar 19, 2023
@mattsse mattsse force-pushed the matt/cleanup-builder branch from 86801f7 to 03b2e6f Compare March 19, 2023 13:01
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2023

Codecov Report

Merging #1838 (03b2e6f) into main (85076fb) will increase coverage by 0.01%.
The diff coverage is 11.11%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
+ Coverage   73.55%   73.57%   +0.01%     
==========================================
  Files         410      410              
  Lines       50509    50497      -12     
==========================================
- Hits        37152    37151       -1     
+ Misses      13357    13346      -11     
Flag Coverage Δ
integration-tests 19.72% <0.00%> (+<0.01%) ⬆️
unit-tests 67.92% <11.11%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/rpc/rpc-builder/src/auth.rs 0.00% <0.00%> (ø)
crates/rpc/rpc-builder/src/lib.rs 66.96% <14.28%> (+1.41%) ⬆️

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 96ae3e7 into main Mar 19, 2023
@mattsse mattsse deleted the matt/cleanup-builder branch March 19, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation C-debt A clean up/refactor of existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants