Skip to content

perf(stages): use regular rayon spawn#1832

Merged
mattsse merged 1 commit intomainfrom
matt/perf-use-regular-spawn
Mar 18, 2023
Merged

perf(stages): use regular rayon spawn#1832
mattsse merged 1 commit intomainfrom
matt/perf-use-regular-spawn

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 18, 2023

the spawn_fifo differs from the regular spawn function:

https://github.com/rayon-rs/rfcs/blob/master/accepted/rfc0001-scope-scheduling.md

spawn_fifo has apparently some additional overhead since there's some syncing involved.

we already sort all the responses so we can just use the regular spawn function

@mattsse mattsse added A-staged-sync Related to staged sync (pipelines and stages) C-perf A change motivated by improving speed, memory usage or disk footprint labels Mar 18, 2023
Copy link
Contributor

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023

Codecov Report

Merging #1832 (ed46de8) into main (661a242) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1832      +/-   ##
==========================================
- Coverage   73.50%   73.49%   -0.02%     
==========================================
  Files         410      410              
  Lines       50510    50515       +5     
==========================================
- Hits        37129    37127       -2     
- Misses      13381    13388       +7     
Flag Coverage Δ
integration-tests 19.73% <0.00%> (+0.02%) ⬆️
unit-tests 67.84% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/stages/src/stages/sender_recovery.rs 91.19% <100.00%> (-0.30%) ⬇️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mattsse mattsse merged commit 995c5ad into main Mar 18, 2023
@mattsse mattsse deleted the matt/perf-use-regular-spawn branch March 18, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-staged-sync Related to staged sync (pipelines and stages) C-perf A change motivated by improving speed, memory usage or disk footprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants