Skip to content

perf: build local pending block without updates #18271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 2 commits into from
Sep 5, 2025
Merged

perf: build local pending block without updates #18271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1b6bd0
perf: build local pending block without updates
mattsse Sep 4, 2025
ccfe792
fmt
mattsse Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions crates/rpc/rpc-eth-api/src/helpers/pending_block.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ use reth_storage_api::{
ReceiptProvider, StateProviderBox, StateProviderFactory,
};
use reth_transaction_pool::{
error::InvalidPoolTransactionError, BestTransactionsAttributes, PoolTransaction,
TransactionPool,
error::InvalidPoolTransactionError, BestTransactions, BestTransactionsAttributes,
PoolTransaction, TransactionPool,
};
use revm::context_interface::Block;
use std::{
Expand Down Expand Up @@ -265,11 +265,14 @@ pub trait LoadPendingBlock:

// Only include transactions if not configured as Empty
if !self.pending_block_kind().is_empty() {
let mut best_txs =
self.pool().best_transactions_with_attributes(BestTransactionsAttributes::new(
let mut best_txs = self
.pool()
.best_transactions_with_attributes(BestTransactionsAttributes::new(
block_env.basefee,
block_env.blob_gasprice().map(|gasprice| gasprice as u64),
));
))
// freeze to get a block as fast as possible
.without_updates();

while let Some(pool_tx) = best_txs.next() {
// ensure we still have capacity for this transaction
Expand Down