Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 36 additions & 28 deletions crates/storage/provider/src/providers/blockchain_provider.rs
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,37 @@ impl<N: ProviderNodeTypes> StateProviderFactory for BlockchainProvider<N> {
}
}

/// Returns a [`StateProviderBox`] indexed by the given block number or tag.
fn state_by_block_number_or_tag(
&self,
number_or_tag: BlockNumberOrTag,
) -> ProviderResult<StateProviderBox> {
match number_or_tag {
BlockNumberOrTag::Latest => self.latest(),
BlockNumberOrTag::Finalized => {
// we can only get the finalized state by hash, not by num
let hash =
self.finalized_block_hash()?.ok_or(ProviderError::FinalizedBlockNotFound)?;
self.state_by_block_hash(hash)
}
BlockNumberOrTag::Safe => {
// we can only get the safe state by hash, not by num
let hash = self.safe_block_hash()?.ok_or(ProviderError::SafeBlockNotFound)?;
self.state_by_block_hash(hash)
}
BlockNumberOrTag::Earliest => {
self.history_by_block_number(self.earliest_block_number()?)
}
BlockNumberOrTag::Pending => self.pending(),
BlockNumberOrTag::Number(num) => {
let hash = self
.block_hash(num)?
.ok_or_else(|| ProviderError::HeaderNotFound(num.into()))?;
self.state_by_block_hash(hash)
}
}
}

fn history_by_block_number(
&self,
block_number: BlockNumber,
Expand Down Expand Up @@ -571,35 +602,12 @@ impl<N: ProviderNodeTypes> StateProviderFactory for BlockchainProvider<N> {
Ok(None)
}

/// Returns a [`StateProviderBox`] indexed by the given block number or tag.
fn state_by_block_number_or_tag(
&self,
number_or_tag: BlockNumberOrTag,
) -> ProviderResult<StateProviderBox> {
match number_or_tag {
BlockNumberOrTag::Latest => self.latest(),
BlockNumberOrTag::Finalized => {
// we can only get the finalized state by hash, not by num
let hash =
self.finalized_block_hash()?.ok_or(ProviderError::FinalizedBlockNotFound)?;
self.state_by_block_hash(hash)
}
BlockNumberOrTag::Safe => {
// we can only get the safe state by hash, not by num
let hash = self.safe_block_hash()?.ok_or(ProviderError::SafeBlockNotFound)?;
self.state_by_block_hash(hash)
}
BlockNumberOrTag::Earliest => {
self.history_by_block_number(self.earliest_block_number()?)
}
BlockNumberOrTag::Pending => self.pending(),
BlockNumberOrTag::Number(num) => {
let hash = self
.block_hash(num)?
.ok_or_else(|| ProviderError::HeaderNotFound(num.into()))?;
self.state_by_block_hash(hash)
}
fn maybe_pending(&self) -> ProviderResult<Option<StateProviderBox>> {
if let Some(pending) = self.canonical_in_memory_state.pending_state() {
return Ok(Some(Box::new(self.block_state_provider(&pending)?)))
}

Ok(None)
}
}

Expand Down
4 changes: 4 additions & 0 deletions crates/storage/provider/src/test_utils/mock.rs
Original file line number Diff line number Diff line change
Expand Up @@ -944,6 +944,10 @@ impl<T: NodePrimitives, ChainSpec: EthChainSpec + Send + Sync + 'static> StatePr
fn pending_state_by_hash(&self, _block_hash: B256) -> ProviderResult<Option<StateProviderBox>> {
Ok(Some(Box::new(self.clone())))
}

fn maybe_pending(&self) -> ProviderResult<Option<StateProviderBox>> {
Ok(Some(Box::new(self.clone())))
}
}

impl<T: NodePrimitives, ChainSpec: Send + Sync> BlockBodyIndicesProvider
Expand Down
18 changes: 13 additions & 5 deletions crates/storage/rpc-provider/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -803,6 +803,10 @@ where
// RPC provider doesn't support pending state by hash
Err(ProviderError::UnsupportedProvider)
}

fn maybe_pending(&self) -> Result<Option<StateProviderBox>, ProviderError> {
Ok(None)
}
}

impl<P, Node, N> DatabaseProviderFactory for RpcBlockchainProvider<P, Node, N>
Expand All @@ -812,8 +816,8 @@ where
Node: NodeTypes,
{
type DB = DatabaseMock;
type ProviderRW = RpcBlockchainStateProvider<P, Node, N>;
type Provider = RpcBlockchainStateProvider<P, Node, N>;
type ProviderRW = RpcBlockchainStateProvider<P, Node, N>;

fn database_provider_ro(&self) -> Result<Self::Provider, ProviderError> {
// RPC provider returns a new state provider
Expand Down Expand Up @@ -1363,14 +1367,14 @@ where
TxMock::default()
}

fn prune_modes_ref(&self) -> &reth_prune_types::PruneModes {
unimplemented!("prune modes not supported for RPC provider")
}

fn disable_long_read_transaction_safety(self) -> Self {
// No-op for RPC provider
self
}

fn prune_modes_ref(&self) -> &reth_prune_types::PruneModes {
unimplemented!("prune modes not supported for RPC provider")
}
}

impl<P, Node, N> BlockNumReader for RpcBlockchainStateProvider<P, Node, N>
Expand Down Expand Up @@ -1817,6 +1821,10 @@ where
// RPC provider doesn't support pending state by hash
Err(ProviderError::UnsupportedProvider)
}

fn maybe_pending(&self) -> ProviderResult<Option<StateProviderBox>> {
Ok(None)
}
}

impl<P, Node, N> ChainSpecProvider for RpcBlockchainStateProvider<P, Node, N>
Expand Down
4 changes: 4 additions & 0 deletions crates/storage/storage-api/src/noop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,10 @@ impl<C: Send + Sync + 'static, N: NodePrimitives> StateProviderFactory for NoopP
fn pending_state_by_hash(&self, _block_hash: B256) -> ProviderResult<Option<StateProviderBox>> {
Ok(Some(Box::new(self.clone())))
}

fn maybe_pending(&self) -> ProviderResult<Option<StateProviderBox>> {
Ok(Some(Box::new(self.clone())))
}
}

impl<C: Send + Sync, N: NodePrimitives> StageCheckpointReader for NoopProvider<C, N> {
Expand Down
5 changes: 5 additions & 0 deletions crates/storage/storage-api/src/state.rs
Original file line number Diff line number Diff line change
Expand Up @@ -194,4 +194,9 @@ pub trait StateProviderFactory: BlockIdReader + Send + Sync {
///
/// If the block couldn't be found, returns `None`.
fn pending_state_by_hash(&self, block_hash: B256) -> ProviderResult<Option<StateProviderBox>>;

/// Returns a pending [`StateProvider`] if it exists.
///
/// This will return `None` if there's no pending state.
fn maybe_pending(&self) -> ProviderResult<Option<StateProviderBox>>;
}
Loading