Skip to content

feat(optimism): Handle incoming flashblocks against current pending block number#18192

Closed
julio4 wants to merge 3 commits intoparadigmxyz:mainfrom
julio4:feat/flashblock-pending-block-height
Closed

feat(optimism): Handle incoming flashblocks against current pending block number#18192
julio4 wants to merge 3 commits intoparadigmxyz:mainfrom
julio4:feat/flashblock-pending-block-height

Conversation

@julio4
Copy link
Contributor

@julio4 julio4 commented Sep 1, 2025

Close #18191
Relevant #17858

When handling a received flashblock (in add_flash_block of Flashblock service):

  • fetch latest block number to calculate pending block height
  • Correctly handle flashblock based on its flashblock.metadata.block_number

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not something that is useful here imo

@mattsse
Copy link
Collaborator

mattsse commented Sep 1, 2025

how does this relate to #18183

@julio4
Copy link
Contributor Author

julio4 commented Sep 1, 2025

how does this relate to #18183

It should implement this todo

} else {
// TODO: store non sequential flashblock index for later processing
debug!("ignoring early {flashblock:?} at current height {latest}");
}

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks,
this is no longer relevant after we made some other simplifications

@mattsse mattsse closed this Sep 2, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Reth Tracker Sep 2, 2025
@julio4 julio4 deleted the feat/flashblock-pending-block-height branch September 2, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Compare incoming flashblock target block number with pending block height

2 participants