feat(optimism): Handle incoming flashblocks against current pending block number#18192
Closed
julio4 wants to merge 3 commits intoparadigmxyz:mainfrom
Closed
feat(optimism): Handle incoming flashblocks against current pending block number#18192julio4 wants to merge 3 commits intoparadigmxyz:mainfrom
julio4 wants to merge 3 commits intoparadigmxyz:mainfrom
Conversation
…urrent pending block height
mattsse
reviewed
Sep 1, 2025
Collaborator
mattsse
left a comment
There was a problem hiding this comment.
not something that is useful here imo
Collaborator
|
how does this relate to #18183 |
Contributor
Author
It should implement this todo reth/crates/optimism/flashblocks/src/service.rs Lines 139 to 142 in 0ad8749 |
mattsse
reviewed
Sep 2, 2025
Collaborator
mattsse
left a comment
There was a problem hiding this comment.
thanks,
this is no longer relevant after we made some other simplifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #18191
Relevant #17858
When handling a received flashblock (in
add_flash_blockof Flashblock service):flashblock.metadata.block_number