Skip to content

perf: optimize single-element collection creation #18168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mediocregopher merged 2 commits into from
Aug 29, 2025
Merged

perf: optimize single-element collection creation #18168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab166da
perf: optimize single-element collection creation
dennsikl Aug 29, 2025
e45fe22
perf: optimize single-element collection creation
dennsikl Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions crates/engine/tree/src/tree/payload_processor/multiproof.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1449,8 +1449,8 @@ mod tests {
let addr2 = B256::random();
let slot1 = B256::random();
let slot2 = B256::random();
targets.insert(addr1, vec![slot1].into_iter().collect());
targets.insert(addr2, vec![slot2].into_iter().collect());
targets.insert(addr1, std::iter::once(slot1).collect());
targets.insert(addr2, std::iter::once(slot2).collect());

let prefetch_proof_targets =
test_state_root_task.get_prefetch_proof_targets(targets.clone());
Expand All @@ -1462,7 +1462,7 @@ mod tests {
// add a different addr and slot to fetched proof targets
let addr3 = B256::random();
let slot3 = B256::random();
test_state_root_task.fetched_proof_targets.insert(addr3, vec![slot3].into_iter().collect());
test_state_root_task.fetched_proof_targets.insert(addr3, std::iter::once(slot3).collect());

let prefetch_proof_targets =
test_state_root_task.get_prefetch_proof_targets(targets.clone());
Expand All @@ -1483,11 +1483,11 @@ mod tests {
let addr2 = B256::random();
let slot1 = B256::random();
let slot2 = B256::random();
targets.insert(addr1, vec![slot1].into_iter().collect());
targets.insert(addr2, vec![slot2].into_iter().collect());
targets.insert(addr1, std::iter::once(slot1).collect());
targets.insert(addr2, std::iter::once(slot2).collect());

// add a subset of the first target to fetched proof targets
test_state_root_task.fetched_proof_targets.insert(addr1, vec![slot1].into_iter().collect());
test_state_root_task.fetched_proof_targets.insert(addr1, std::iter::once(slot1).collect());

let prefetch_proof_targets =
test_state_root_task.get_prefetch_proof_targets(targets.clone());
Expand All @@ -1510,12 +1510,12 @@ mod tests {
assert!(prefetch_proof_targets.contains_key(&addr1));
assert_eq!(
*prefetch_proof_targets.get(&addr1).unwrap(),
vec![slot3].into_iter().collect::<B256Set>()
std::iter::once(slot3).collect::<B256Set>()
);
assert!(prefetch_proof_targets.contains_key(&addr2));
assert_eq!(
*prefetch_proof_targets.get(&addr2).unwrap(),
vec![slot2].into_iter().collect::<B256Set>()
std::iter::once(slot2).collect::<B256Set>()
);
}

Expand Down
4 changes: 2 additions & 2 deletions crates/trie/common/src/proofs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,8 +989,8 @@ mod tests {
// populate some targets
let (addr1, addr2) = (B256::random(), B256::random());
let (slot1, slot2) = (B256::random(), B256::random());
targets.insert(addr1, vec![slot1].into_iter().collect());
targets.insert(addr2, vec![slot2].into_iter().collect());
targets.insert(addr1, std::iter::once(slot1).collect());
targets.insert(addr2, std::iter::once(slot2).collect());

let mut retained = targets.clone();
retained.retain_difference(&Default::default());
Expand Down