Skip to content

test(optimism): Cover the failure case of decoding a non-binary message in WsFlashBlockStream #18166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RomanHodulak merged 1 commit into from
Sep 1, 2025
Merged

test(optimism): Cover the failure case of decoding a non-binary message in WsFlashBlockStream #18166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion crates/optimism/flashblocks/src/ws/stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ mod tests {
use alloy_primitives::bytes::Bytes;
use brotli::enc::BrotliEncoderParams;
use std::future;
use tokio_tungstenite::tungstenite::Error;
use tokio_tungstenite::tungstenite::{Error, Utf8Bytes};

/// A `FakeConnector` creates [`FakeStream`].
///
Expand Down Expand Up @@ -284,4 +284,18 @@ mod tests {

assert_eq!(actual_messages, expected_messages);
}

#[tokio::test]
async fn test_stream_fails_to_decode_non_binary_message() {
let messages = FakeConnector::from([Ok(Message::Text(Utf8Bytes::from("test")))]);
let ws_url = "http://localhost".parse().unwrap();
let stream = WsFlashBlockStream::with_connector(ws_url, messages);

let actual_messages: Vec<_> =
stream.map(Result::unwrap_err).map(|e| format!("{e}")).collect().await;
let expected_messages =
vec!["Unexpected websocket message: Text(Utf8Bytes(b\"test\"))".to_owned()];

assert_eq!(actual_messages, expected_messages);
}
}
Loading