Skip to content

fix(optimism): Fail if latest and base flashblock parent are different #18132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 2 commits into from
Aug 28, 2025
Merged

fix(optimism): Fail if latest and base flashblock parent are different #18132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd3eb3f
fix(optimism): Fail if latest and base flashblock parent are different
RomanHodulak Aug 28, 2025
a818666
fix(optimism): Flip comparison latest == parent for failure
RomanHodulak Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/optimism/flashblocks/src/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use crate::{ExecutionPayloadBaseV1, FlashBlock};
use alloy_eips::{eip2718::WithEncoded, BlockNumberOrTag, Decodable2718};
use eyre::OptionExt;
use eyre::{eyre, OptionExt};
use futures_util::{FutureExt, Stream, StreamExt};
use reth_chain_state::{CanonStateNotifications, CanonStateSubscriptions, ExecutedBlock};
use reth_errors::RethError;
Expand Down Expand Up @@ -129,6 +129,10 @@ impl<
.find_map(|v| v.base.clone())
.ok_or_eyre("Missing base flashblock")?;

if attrs.parent_hash != latest.hash() {
return Err(eyre!("The base flashblock is old"));
}

let state_provider = self.provider.history_by_block_hash(latest.hash())?;
let state = StateProviderDatabase::new(&state_provider);
let mut db = State::builder().with_database(state).with_bundle_update().build();
Expand Down