Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 57 additions & 1 deletion crates/transaction-pool/src/validate/eth.rs
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,11 @@ impl<Client, Tx> EthTransactionValidator<Client, Tx> {
pub fn max_tx_input_bytes(&self) -> usize {
self.inner.max_tx_input_bytes
}

/// Returns whether balance checks are disabled for this validator.
pub fn disable_balance_check(&self) -> bool {
self.inner.disable_balance_check
}
}

impl<Client, Tx> EthTransactionValidator<Client, Tx>
Expand Down Expand Up @@ -233,6 +238,8 @@ pub(crate) struct EthTransactionValidatorInner<Client, T> {
max_tx_input_bytes: usize,
/// Maximum gas limit for individual transactions
max_tx_gas_limit: Option<u64>,
/// Disable balance checks during transaction validation
disable_balance_check: bool,
/// Marker for the transaction type
_marker: PhantomData<T>,
/// Metrics for tsx pool validation
Expand Down Expand Up @@ -610,7 +617,7 @@ where
let cost = transaction.cost();

// Checks for max cost
if cost > &account.balance {
if !self.disable_balance_check && cost > &account.balance {
let expected = *cost;
return TransactionValidationOutcome::Invalid(
transaction,
Expand Down Expand Up @@ -809,6 +816,8 @@ pub struct EthTransactionValidatorBuilder<Client> {
max_tx_input_bytes: usize,
/// Maximum gas limit for individual transactions
max_tx_gas_limit: Option<u64>,
/// Disable balance checks during transaction validation
disable_balance_check: bool,
}

impl<Client> EthTransactionValidatorBuilder<Client> {
Expand Down Expand Up @@ -852,6 +861,9 @@ impl<Client> EthTransactionValidatorBuilder<Client> {

// max blob count is prague by default
max_blob_count: BlobParams::prague().max_blobs_per_tx,

// balance checks are enabled by default
disable_balance_check: false,
}
}

Expand Down Expand Up @@ -1007,6 +1019,12 @@ impl<Client> EthTransactionValidatorBuilder<Client> {
self
}

/// Disables balance checks during transaction validation
pub const fn disable_balance_check(mut self) -> Self {
self.disable_balance_check = true;
self
}

/// Builds a the [`EthTransactionValidator`] without spawning validator tasks.
pub fn build<Tx, S>(self, blob_store: S) -> EthTransactionValidator<Client, Tx>
where
Expand All @@ -1029,6 +1047,7 @@ impl<Client> EthTransactionValidatorBuilder<Client> {
local_transactions_config,
max_tx_input_bytes,
max_tx_gas_limit,
disable_balance_check,
..
} = self;

Expand Down Expand Up @@ -1061,6 +1080,7 @@ impl<Client> EthTransactionValidatorBuilder<Client> {
local_transactions_config,
max_tx_input_bytes,
max_tx_gas_limit,
disable_balance_check,
_marker: Default::default(),
validation_metrics: TxPoolValidationMetrics::default(),
};
Expand Down Expand Up @@ -1610,4 +1630,40 @@ mod tests {
let invalid = outcome.as_invalid().unwrap();
assert!(invalid.is_oversized());
}

#[tokio::test]
async fn valid_with_disabled_balance_check() {
let transaction = get_transaction();
let provider = MockEthProvider::default();

// Set account with 0 balance
provider.add_account(
transaction.sender(),
ExtendedAccount::new(transaction.nonce(), alloy_primitives::U256::ZERO),
);

// Valdiate with balance check enabled
let validator = EthTransactionValidatorBuilder::new(provider.clone())
.build(InMemoryBlobStore::default());

let outcome = validator.validate_one(TransactionOrigin::External, transaction.clone());
let expected_cost = *transaction.cost();
if let TransactionValidationOutcome::Invalid(_, err) = outcome {
assert!(matches!(
err,
InvalidPoolTransactionError::Consensus(InvalidTransactionError::InsufficientFunds(ref funds_err))
if funds_err.got == alloy_primitives::U256::ZERO && funds_err.expected == expected_cost
));
} else {
panic!("Expected Invalid outcome with InsufficientFunds error");
}

// Valdiate with balance check disabled
let validator = EthTransactionValidatorBuilder::new(provider)
.disable_balance_check() // This should allow the transaction through despite zero balance
.build(InMemoryBlobStore::default());

let outcome = validator.validate_one(TransactionOrigin::External, transaction);
assert!(outcome.is_valid()); // Should be valid because balance check is disabled
}
}
Loading