Skip to content

feat(optimism): add supervisor_revalidation_duration_seconds metrics #17897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 1 commit into from
Aug 20, 2025
Merged

feat(optimism): add supervisor_revalidation_duration_seconds metrics #17897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions crates/optimism/txpool/src/maintain.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@ use crate::{
};
use alloy_consensus::{conditional::BlockConditionalAttributes, BlockHeader};
use futures_util::{future::BoxFuture, FutureExt, Stream, StreamExt};
use metrics::Gauge;
use metrics::{Gauge, Histogram};
use reth_chain_state::CanonStateNotification;
use reth_metrics::{metrics::Counter, Metrics};
use reth_primitives_traits::NodePrimitives;
use reth_transaction_pool::{error::PoolTransactionError, PoolTransaction, TransactionPool};
use std::time::Instant;
use tracing::warn;

/// Transaction pool maintenance metrics
Expand Down Expand Up @@ -50,7 +51,8 @@ struct MaintainPoolInteropMetrics {
/// Counter for interop transactions that became stale and need revalidation
stale_interop_transactions: Counter,
// TODO: we also should add metric for (hash, counter) to check number of validation per tx
// TODO: we should add some timing metric in here to check supervisor congestion
/// Histogram for measuring supervisor revalidation duration (congestion metric)
supervisor_revalidation_duration_seconds: Histogram,
}

impl MaintainPoolInteropMetrics {
Expand All @@ -67,6 +69,12 @@ impl MaintainPoolInteropMetrics {
fn inc_stale_tx_interop(&self, count: usize) {
self.stale_interop_transactions.increment(count as u64);
}

/// Record supervisor revalidation duration
#[inline]
fn record_supervisor_duration(&self, duration: std::time::Duration) {
self.supervisor_revalidation_duration_seconds.record(duration.as_secs_f64());
}
}
/// Returns a spawnable future for maintaining the state of the conditional txs in the transaction
/// pool.
Expand Down Expand Up @@ -179,6 +187,7 @@ pub async fn maintain_transaction_pool_interop<N, Pool, St>(
if !to_revalidate.is_empty() {
metrics.inc_stale_tx_interop(to_revalidate.len());

let revalidation_start = Instant::now();
let revalidation_stream = supervisor_client.revalidate_interop_txs_stream(
to_revalidate,
timestamp,
Expand Down Expand Up @@ -211,6 +220,8 @@ pub async fn maintain_transaction_pool_interop<N, Pool, St>(
}
}
}

metrics.record_supervisor_duration(revalidation_start.elapsed());
}

if !to_remove.is_empty() {
Expand Down