fix: use StateCommitment

[robinsdan]

The current implementation ignored the StateCommitment constraint

[mattsse]

i dont understand what this fixes, can you elaborate

does this make sense @Rjected

[robinsdan]

@mattsse Wasn't the introduction of the StateCommitment trait intended to abstract the implementation of the Database? However, the current implementation uses a fixed type, StateRoot, StorageRoot, etc, which assumes that StateCommitment is equivalent to MerklePatriciaTrie.

reth/crates/trie/db/src/commitment.rs

Lines 27 to 39 in fe53ec5

	pub struct MerklePatriciaTrie;
	impl StateCommitment for MerklePatriciaTrie {
	type StateRoot<'a, TX: DbTx + 'a> =
	StateRoot<DatabaseTrieCursorFactory<'a, TX>, DatabaseHashedCursorFactory<'a, TX>>;
	type StorageRoot<'a, TX: DbTx + 'a> =
	StorageRoot<DatabaseTrieCursorFactory<'a, TX>, DatabaseHashedCursorFactory<'a, TX>>;
	type StateProof<'a, TX: DbTx + 'a> =
	Proof<DatabaseTrieCursorFactory<'a, TX>, DatabaseHashedCursorFactory<'a, TX>>;
	type StateWitness<'a, TX: DbTx + 'a> =
	TrieWitness<DatabaseTrieCursorFactory<'a, TX>, DatabaseHashedCursorFactory<'a, TX>>;
	type KeyHasher = KeccakKeyHasher;
	}

[Rjected]

The intention of this abstraction was to allow customization of the state root algorithm yes, but I think it has failed at doing that because there are too many parts of the code which assume MPT and the abstraction only handles certain db related traits. I am going to close this PR as I think it makes the code more verbose, but I would instead support removing the StateCommitment trait