Skip to content

feat(rpc): kickoff geth traces#1772

Merged
gakonst merged 2 commits intomainfrom
matt/start-debug-trace
Mar 19, 2023
Merged

feat(rpc): kickoff geth traces#1772
gakonst merged 2 commits intomainfrom
matt/start-debug-trace

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 15, 2023

Adds missing config

Add default struct log tracing

custom call,4byte,prestate left unimplemented for now, need followup

@mattsse mattsse added the A-rpc Related to the RPC implementation label Mar 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

Merging #1772 (18c94b9) into main (0128d42) will decrease coverage by 0.14%.
The diff coverage is 10.98%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1772      +/-   ##
==========================================
- Coverage   73.56%   73.42%   -0.14%     
==========================================
  Files         415      415              
  Lines       50469    50545      +76     
==========================================
- Hits        37128    37114      -14     
- Misses      13341    13431      +90     
Flag Coverage Δ
integration-tests 19.71% <6.59%> (-0.01%) ⬇️
unit-tests 67.78% <8.79%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/revm/revm-inspectors/src/tracing/builder/geth.rs 0.00% <0.00%> (ø)
...revm/revm-inspectors/src/tracing/builder/parity.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/config.rs 0.00% <ø> (ø)
crates/revm/revm-inspectors/src/tracing/mod.rs 0.00% <0.00%> (ø)
crates/rpc/rpc/src/trace.rs 49.00% <0.00%> (ø)
crates/rpc/rpc/src/debug.rs 16.21% <3.92%> (-11.91%) ⬇️
crates/rpc/rpc-types/src/eth/trace/geth/mod.rs 12.28% <4.00%> (-6.47%) ⬇️
crates/rpc/rpc/src/eth/error.rs 9.25% <33.33%> (-0.09%) ⬇️
crates/rpc/rpc-types/src/eth/trace/geth/call.rs 100.00% <100.00%> (ø)
...ates/rpc/rpc-types/src/eth/trace/geth/pre_state.rs 93.75% <100.00%> (ø)
... and 2 more

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mattsse mattsse force-pushed the matt/start-debug-trace branch from 6708079 to a7c844b Compare March 19, 2023 17:06
@mattsse mattsse added the C-enhancement New feature or request label Mar 19, 2023
@mattsse mattsse marked this pull request as ready for review March 19, 2023 17:07
@mattsse mattsse requested a review from gakonst as a code owner March 19, 2023 17:07
@mattsse mattsse force-pushed the matt/start-debug-trace branch from a7c844b to 0110d42 Compare March 19, 2023 17:09
@mattsse mattsse force-pushed the matt/start-debug-trace branch from 0110d42 to 18c94b9 Compare March 19, 2023 17:15
@mattsse mattsse changed the title wip:feat(rpc): kickoff geth traces feat(rpc): kickoff geth traces Mar 19, 2023
@gakonst gakonst merged commit 0936523 into main Mar 19, 2023
@gakonst gakonst deleted the matt/start-debug-trace branch March 19, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation C-enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants