Skip to content

perf: use debug_assert for parked pool lookup #17712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 4 commits into from
Sep 9, 2025
Merged

perf: use debug_assert for parked pool lookup #17712

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
837f7e2
refactor remove extra comp
malik672 Aug 2, 2025
bc21ddc
fix logic
malik672 Aug 2, 2025
78fd218
Merge branch 'main' into playdate
mattsse Aug 29, 2025
c1eab7d
chore: use debug_assert
mattsse Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions crates/transaction-pool/src/pool/parked.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,11 @@ impl<T: ParkedOrd> ParkedPool<T> {
/// If the transaction is already included.
pub fn add_transaction(&mut self, tx: Arc<ValidPoolTransaction<T::Transaction>>) {
let id = *tx.id();
let checker = self.get(&id);
assert!(
!self.contains(&id),
checker.is_none(),
"transaction already included {:?}",
self.get(&id).unwrap().transaction.transaction
checker.unwrap().transaction.transaction
);
let submission_id = self.next_id();

Expand Down
Loading