Skip to content

chore(trie): fully reveal sparse tries prior to leaf updates/removals #17643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mediocregopher merged 37 commits into from
Aug 22, 2025
Merged

chore(trie): fully reveal sparse tries prior to leaf updates/removals #17643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
190524c
chore(trie): fully reveal sparse tries prior to leaf updates/removals
mediocregopher Jul 23, 2025
4a7c73f
Merge remote-tracking branch 'upstream/main' into mediocregopher/1757…
mediocregopher Jul 28, 2025
cf12967
only_sibling -> sole_sibling for better clarity
mediocregopher Jul 28, 2025
37572ea
Update alloy-trie, add trace span to storage proof calc
mediocregopher Jul 31, 2025
51f047e
SerialSparseTrie tracing
mediocregopher Jul 31, 2025
6463e81
Perform leaf updates prior to leaf removals
mediocregopher Jul 31, 2025
9040cfc
Use AddedRemovedKeys to always regenerate proofs for removed branch c…
mediocregopher Aug 1, 2025
7742426
debug
mediocregopher Aug 4, 2025
7e53361
Pass AddedRemovedKeys into TrieWalker
mediocregopher Aug 5, 2025
5848cb6
Fix for TrieWalker can skip check
mediocregopher Aug 5, 2025
62d583d
debug
mediocregopher Aug 5, 2025
cc7ef25
Track account removals in AddedRemovedKeys
mediocregopher Aug 5, 2025
da65ce9
Merge remote-tracking branch 'upstream/main' into mediocregopher/1757…
mediocregopher Aug 5, 2025
d33a8b6
Cleanup
mediocregopher Aug 5, 2025
b238e17
Don't track removed leaves as non-targets
mediocregopher Aug 5, 2025
3399765
Pass MultiAddedRemovedKeys using an Arc rather than cloning
mediocregopher Aug 5, 2025
d3e58b6
Pass AddedRemovedKeys as references
mediocregopher Aug 5, 2025
dcdeddc
Fix extension nodes
mediocregopher Aug 6, 2025
6bfae51
Tests and TODOs
mediocregopher Aug 6, 2025
30fff28
Fix bug in AddedRemovedKeys::update_from_state
mediocregopher Aug 6, 2025
009c2c9
alloy trie branch
mediocregopher Aug 6, 2025
a34deb5
Clippy and fmt
mediocregopher Aug 6, 2025
0799c3e
Update alloy trie dependency
mediocregopher Aug 6, 2025
81f09dc
Track leaf additions in MultiAddedRemovedKeys
mediocregopher Aug 7, 2025
6269d89
alloy-trie update
mediocregopher Aug 7, 2025
555566e
Revert back to before tracking added keys
mediocregopher Aug 7, 2025
72cbaae
alloy-trie update
mediocregopher Aug 7, 2025
c5fb4ce
update alloy-trie
mediocregopher Aug 8, 2025
9110060
PR feedback
mediocregopher Aug 18, 2025
d194108
Use merged alloy-trie
mediocregopher Aug 19, 2025
9f24f5a
Merge remote-tracking branch 'upstream/main' into mediocregopher/1757…
mediocregopher Aug 19, 2025
fb518aa
Comment patch
mediocregopher Aug 19, 2025
309efa3
ci
mediocregopher Aug 19, 2025
8e12a0a
Update crates/trie/common/src/added_removed_keys.rs
mediocregopher Aug 21, 2025
3e1d658
Merge branch 'main' into mediocregopher/17571-leaf-updates-removals
mediocregopher Aug 21, 2025
8b8ad16
fix unused dep
mediocregopher Aug 21, 2025
5ce7a09
doc fix
mediocregopher Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ alloy-primitives = { version = "1.3.1", default-features = false, features = ["m
alloy-rlp = { version = "0.3.10", default-features = false, features = ["core-net"] }
alloy-sol-macro = "1.3.1"
alloy-sol-types = { version = "1.3.1", default-features = false }
alloy-trie = { version = "0.9.0", default-features = false }
alloy-trie = { version = "0.9.1", default-features = false }

alloy-hardforks = "0.2.7"

Expand Down
1 change: 1 addition & 0 deletions crates/engine/tree/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ futures.workspace = true
thiserror.workspace = true
tokio = { workspace = true, features = ["rt", "rt-multi-thread", "sync", "macros"] }
mini-moka = { workspace = true, features = ["sync"] }
smallvec.workspace = true

# metrics
metrics.workspace = true
Expand Down
Loading
Loading