feat(stages): add table checkpoint to AccountHashing and StorageHashing#1667
Merged
feat(stages): add table checkpoint to AccountHashing and StorageHashing#1667
AccountHashing and StorageHashing#1667Conversation
joshieDo
added
S-blocked
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1667 +/- ##
==========================================
- Coverage 72.65% 72.63% -0.02%
==========================================
Files 392 393 +1
Lines 47168 47281 +113
==========================================
+ Hits 34269 34342 +73
- Misses 12899 12939 +40
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gakonst
reviewed
Mar 14, 2023
gakonst
approved these changes
Mar 14, 2023
Comment on lines
+127
to
+137
| // Address caching for the first iteration when current_key | ||
| // is None | ||
| let keccak_address = | ||
| if let Some(keccak_address) = keccak_address { | ||
| keccak_address | ||
| } else { | ||
| keccak256(address) | ||
| }; | ||
|
|
||
| // TODO cache map keccak256(slot.key) ? | ||
| ((keccak_address, keccak256(slot.key)), slot.value) |
Member
There was a problem hiding this comment.
yeah probably right solution here is just to have a LRU maps for map<address, keccak256(address)> and map<h256, keccak256(h256)> to avoid redundant hashing, but doubt it'll be a bottleneck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to/blocked by/branch out of #1656
Removes
tx.commitfrom the hashing stages and uses checkpoints throughtables::SyncStageProgress