Conversation
Rjected
approved these changes
Nov 4, 2022
Member
Rjected
left a comment
Rjected
left a comment
There was a problem hiding this comment.
The max missed pings part is not part of the protocol, this strategy is just something that akula does. We can differ, disconnecting after a single missed pong is much simpler and makes sense given the typical timeout parameters
emhane
pushed a commit
to JoshdfG/reth
that referenced
this pull request
Jan 5, 2026
JoshdfG
pushed a commit
to JoshdfG/reth
that referenced
this pull request
Jan 16, 2026
emhane
pushed a commit
to JoshdfG/reth
that referenced
this pull request
Jan 21, 2026
dhyaniarun1993
pushed a commit
to dhyaniarun1993/reth
that referenced
this pull request
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies pinging drastically.
Intervalfor ping intervalSleepfor expected pongThis also gets rid of max missed pongs, imo we should terminate at first missed pong.
or is this protocol related or something that geth/erigon do @Rjected ?