Skip to content

chore: add tx type constants#1639

Merged
mattsse merged 2 commits intomainfrom
matt/add-tx-type-constants
Mar 5, 2023
Merged

chore: add tx type constants#1639
mattsse merged 2 commits intomainfrom
matt/add-tx-type-constants

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 5, 2023

add constants, will be required by #1498 for example

cc @chirag-bgh

@mattsse mattsse requested a review from gakonst as a code owner March 5, 2023 09:45
@mattsse mattsse requested a review from rkrasiuk March 5, 2023 09:45
@mattsse mattsse added the C-debt A clean up/refactor of existing code label Mar 5, 2023
@mattsse mattsse force-pushed the matt/add-tx-type-constants branch from 5d826a6 to e445f95 Compare March 5, 2023 09:54
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2023

Codecov Report

Merging #1639 (fbc6109) into main (31f62c1) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1639      +/-   ##
==========================================
- Coverage   74.44%   74.42%   -0.02%     
==========================================
  Files         377      377              
  Lines       45197    45197              
==========================================
- Hits        33647    33639       -8     
- Misses      11550    11558       +8     
Flag Coverage Δ
integration-tests 20.95% <0.00%> (+<0.01%) ⬆️
unit-tests 69.02% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/primitives/src/lib.rs 100.00% <ø> (ø)
crates/primitives/src/transaction/mod.rs 90.02% <ø> (ø)
crates/primitives/src/transaction/tx_type.rs 70.83% <0.00%> (ø)
crates/net/discv4/src/proto.rs 89.66% <0.00%> (-3.13%) ⬇️
crates/net/downloaders/src/bodies/task.rs 95.45% <0.00%> (-1.14%) ⬇️
crates/net/network/src/session/active.rs 84.59% <0.00%> (-0.75%) ⬇️
crates/net/eth-wire/src/capability.rs 74.26% <0.00%> (-0.74%) ⬇️
crates/net/discv4/src/lib.rs 65.95% <0.00%> (-0.15%) ⬇️
crates/net/downloaders/src/headers/task.rs 83.67% <0.00%> (ø)
crates/net/network/src/session/mod.rs 77.94% <0.00%> (+1.35%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mattsse mattsse merged commit 9dfee49 into main Mar 5, 2023
@mattsse mattsse deleted the matt/add-tx-type-constants branch March 5, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-debt A clean up/refactor of existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants