Skip to content

chore: expose methods and structs#1607

Merged
rakita merged 3 commits intomainfrom
rkrasiuk/expose-cli-methods
Mar 2, 2023
Merged

chore: expose methods and structs#1607
rakita merged 3 commits intomainfrom
rkrasiuk/expose-cli-methods

Conversation

@rkrasiuk
Copy link
Contributor

@rkrasiuk rkrasiuk commented Mar 2, 2023

Expose some cli and sync structs for external usage.

@rkrasiuk rkrasiuk added the A-meta Changes in the contributor workflow and planning label Mar 2, 2023
@rkrasiuk rkrasiuk requested a review from mattsse March 2, 2023 13:01
@rkrasiuk rkrasiuk marked this pull request as ready for review March 2, 2023 13:01
@rkrasiuk rkrasiuk requested a review from onbjerg as a code owner March 2, 2023 13:01
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Merging #1607 (bc6643a) into main (626c076) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1607      +/-   ##
==========================================
- Coverage   74.80%   74.77%   -0.03%     
==========================================
  Files         374      374              
  Lines       44512    44512              
==========================================
- Hits        33295    33283      -12     
- Misses      11217    11229      +12     
Flag Coverage Δ
integration-tests 21.18% <0.00%> (+0.01%) ⬆️
unit-tests 69.36% <33.33%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bin/reth/src/cli.rs 0.00% <0.00%> (ø)
bin/reth/src/dirs.rs 52.63% <ø> (ø)
crates/stages/src/stages/headers.rs 95.41% <100.00%> (ø)
crates/net/discv4/src/proto.rs 89.66% <0.00%> (-3.13%) ⬇️
crates/net/eth-wire/src/ethstream.rs 83.97% <0.00%> (-0.48%) ⬇️
crates/net/network/src/peers/manager.rs 82.46% <0.00%> (-0.09%) ⬇️
crates/net/downloaders/src/headers/task.rs 83.67% <0.00%> (ø)
crates/stages/src/stages/bodies.rs 92.85% <0.00%> (+0.42%) ⬆️
crates/primitives/src/net.rs 96.92% <0.00%> (+0.51%) ⬆️
crates/stages/src/stages/sender_recovery.rs 91.48% <0.00%> (+0.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rakita rakita merged commit 6501ce2 into main Mar 2, 2023
@rakita rakita deleted the rkrasiuk/expose-cli-methods branch March 2, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Changes in the contributor workflow and planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants