Skip to content

chore(deps): rm unused deps in primitives#1604

Merged
mattsse merged 4 commits intomainfrom
matt/rm-unused-deps-in-primitives
Mar 2, 2023
Merged

chore(deps): rm unused deps in primitives#1604
mattsse merged 4 commits intomainfrom
matt/rm-unused-deps-in-primitives

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 2, 2023

Closes #1603
Closes #1602
Closes #1451

@mattsse mattsse added the A-dependencies Pull requests or issues that are about dependencies label Mar 2, 2023
@mattsse mattsse requested a review from gakonst as a code owner March 2, 2023 11:17
@rakita rakita self-requested a review March 2, 2023 11:51
@rakita
Copy link
Collaborator

rakita commented Mar 2, 2023

Some build of tests failed

@mattsse
Copy link
Collaborator Author

mattsse commented Mar 2, 2023

checking

@mattsse mattsse force-pushed the matt/rm-unused-deps-in-primitives branch from fe0d3f6 to 986a9c3 Compare March 2, 2023 12:24
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Merging #1604 (308a113) into main (626c076) will decrease coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1604      +/-   ##
==========================================
- Coverage   74.80%   74.79%   -0.01%     
==========================================
  Files         374      374              
  Lines       44512    44512              
==========================================
- Hits        33295    33294       -1     
- Misses      11217    11218       +1     
Flag Coverage Δ
integration-tests 21.15% <ø> (-0.02%) ⬇️
unit-tests 69.39% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/net/network/src/session/active.rs 84.59% <0.00%> (-0.60%) ⬇️
crates/net/discv4/src/lib.rs 65.67% <0.00%> (-0.15%) ⬇️
crates/net/network/src/peers/manager.rs 82.46% <0.00%> (-0.09%) ⬇️
crates/net/eth-wire/src/p2pstream.rs 79.58% <0.00%> (+0.17%) ⬆️
crates/net/network/src/manager.rs 52.49% <0.00%> (+0.18%) ⬆️
crates/storage/provider/src/transaction.rs 84.72% <0.00%> (+0.19%) ⬆️
crates/stages/src/stages/bodies.rs 92.85% <0.00%> (+0.42%) ⬆️
crates/primitives/src/net.rs 96.92% <0.00%> (+0.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mattsse mattsse merged commit 9326b45 into main Mar 2, 2023
@mattsse mattsse deleted the matt/rm-unused-deps-in-primitives branch March 2, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-dependencies Pull requests or issues that are about dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: some installed deps are not needed bug: deps sanity check failed derive_arbitrary macro fails to compile if not all features enabled

3 participants