Skip to content

fix(rpc): make exp claim optional#1601

Merged
gakonst merged 2 commits intomainfrom
dan/optional-claim
Mar 1, 2023
Merged

fix(rpc): make exp claim optional#1601
gakonst merged 2 commits intomainfrom
dan/optional-claim

Conversation

@Rjected
Copy link
Member

@Rjected Rjected commented Mar 1, 2023

The exp claim is not required, and is not sent in engine API hive tests. So it is made optional.

Fixes #1587

Rjected added 2 commits March 1, 2023 17:05
 * The `exp` claim is not required, and is not sent in engine API hive
   tests. So it is made optional
@Rjected Rjected requested a review from gakonst as a code owner March 1, 2023 22:11
@Rjected Rjected requested a review from mattsse March 1, 2023 22:11
@Rjected Rjected added the A-rpc Related to the RPC implementation label Mar 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023

Codecov Report

Merging #1601 (efe9c5b) into main (2884eae) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1601      +/-   ##
==========================================
- Coverage   74.81%   74.80%   -0.01%     
==========================================
  Files         374      374              
  Lines       44249    44411     +162     
==========================================
+ Hits        33105    33222     +117     
- Misses      11144    11189      +45     
Flag Coverage Δ
integration-tests 21.03% <0.00%> (-0.10%) ⬇️
unit-tests 69.46% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/rpc/rpc/src/layers/auth_layer.rs 99.20% <100.00%> (ø)
crates/rpc/rpc/src/layers/jwt_secret.rs 96.86% <100.00%> (+0.17%) ⬆️
crates/net/network/src/session/mod.rs 76.59% <0.00%> (-1.36%) ⬇️
crates/net/downloaders/src/headers/task.rs 83.67% <0.00%> (-1.03%) ⬇️
crates/stages/src/stages/sender_recovery.rs 90.95% <0.00%> (-0.54%) ⬇️
crates/net/eth-wire/src/ethstream.rs 83.97% <0.00%> (-0.48%) ⬇️
crates/stages/src/stages/hashing_storage.rs 95.62% <0.00%> (-0.37%) ⬇️
crates/stages/src/stages/merkle.rs 77.70% <0.00%> (ø)
crates/primitives/src/chain/spec.rs 97.87% <0.00%> (ø)
crates/executor/src/execution_result.rs
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gakonst gakonst merged commit ad0ce8c into main Mar 1, 2023
@gakonst gakonst deleted the dan/optional-claim branch March 1, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot parse JWT claim with no exp field

4 participants