feat(rpc): integrate eth cache and task executor in pipeline#1596
Merged
feat(rpc): integrate eth cache and task executor in pipeline#1596
Conversation
mattsse
added
C-enhancement
mattsse
force-pushed
the
matt/integrate-cache-and-task-in-rpc-pipeline
branch
2 times, most recently
from
9522a71 to
0ff9c3a
Compare
mattsse
force-pushed
the
matt/integrate-cache-and-task-in-rpc-pipeline
branch
from
0ff9c3a to
2302294
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1596 +/- ##
==========================================
- Coverage 74.81% 74.79% -0.03%
==========================================
Files 374 374
Lines 44249 44350 +101
==========================================
+ Hits 33105 33171 +66
- Misses 11144 11179 +35
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mattsse
force-pushed
the
matt/integrate-cache-and-task-in-rpc-pipeline
branch
from
24e3a9c to
2d892a6
Compare
mattsse
force-pushed
the
matt/integrate-cache-and-task-in-rpc-pipeline
branch
from
2d892a6 to
cdd4937
Compare
gakonst
approved these changes
Mar 1, 2023
Comment on lines
+536
to
+540
| /// Returns the [EthStateCache] frontend | ||
| /// | ||
| /// This will spawn exactly one [EthStateCache] service if this is the first time the cache is | ||
| /// requested. | ||
| pub fn eth_cache(&mut self) -> EthStateCache { |
Member
There was a problem hiding this comment.
assuming this is a cheap clone cuz the thing we're cloning only stores the channels
Collaborator
Author
There was a problem hiding this comment.
yes only clones a sender
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates new
EthCacheinto rpc-builder pipeline and adds TaskSpawner support which is also required for installing Eth pubsub